Repository navigation
Conversation
Homebrew warns on every command that loads this cask because `postflight` is deprecated. Keep the macOS quarantine xattr strip, expressed as declarative install steps with an on_macos guard so Linux installs still skip /usr/bin/xattr.
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
Pull request overview
Updates the Homebrew cask to use the current postflight_steps DSL while preserving macOS quarantine removal.
Changes:
- Replaces deprecated
postflightsyntax. - Uses macOS-only
on_macosandrunsteps.
File summaries
| File | Summary |
|---|---|
Casks/mnemon.rb |
Migrates the quarantine-removal hook to the supported DSL. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebrew now warns on every
brewcommand that touches this cask:This keeps the same quarantine strip (
xattr -dr com.apple.quarantineon the stagedmnemonbinary) but usespostflight_steps+on_macos+run, which is the current Homebrew DSL. The macOS-only guard is unchanged so a Linuxbrew installstill does not invoke/usr/bin/xattr.Verified locally:
brew info --cask mnemon-dev/tap/mnemonwith this stanza emits nopostflightdeprecation warning.GoReleaser still emits
postflightfromhomebrew_casks.hooks.post.install(goreleaser/goreleaser#6873 is open). A companion change in mnemon-dev/mnemon will stop the next release from regenerating the old stanza.