Skip to content

[Metal] Fix fill loop in layer_norm #4772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zcbenz merged 1 commit into from
Oct 31, 2026
Merged

[Metal] Fix fill loop in layer_norm #4772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mlx/backend/metal/kernels/layer_norm.metal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ template <typename T, int N_READS = 8>

// Compute some variables for reading writing etc
const bool safe = lid * N_READS + N_READS <= axis_size;
const int n = axis_size - lid * N_READS;
const int n = max(int(axis_size) - int(lid * N_READS), 0);

// Read the inputs
if (safe) {
Expand Down Expand Up @@ -235,7 +235,7 @@ template <typename T, int N_READS = 8>

// Compute some variables for reading writing etc
const bool safe = lid * N_READS + N_READS <= axis_size;
const int n = axis_size - lid * N_READS;
const int n = max(int(axis_size) - int(lid * N_READS), 0);

// Read the inputs
if (safe) {
Expand Down
Loading