Repository navigation
Fix split-K test compatibility on M5, M6 - #4677
Merged
Merged
Conversation
magnuslundstedt
commented
Oct 10, 2026
Contributor
- ☑️ I understand it is strictly prohibited to use AI to write PR description
- Fixes [BUG] test_qmm_splitk_precision fails on Apple silicon generation 17 or later (M=16) #4676
- What: One-line change to test so every M routes to split-K on all GPU generations, no kernel changes
- Why: M=16 is below get_qmv_batch_limit on generation 17 or later GPU and on d parts, so the test did not always test the split-K path
- Verified: before FAILED (failures=2), after OK on M5 Air and M6 (macOS 27), default environment and TF32=0
- AI usage disclosure: AI agents assisted in discovering the issue, performing the measurements and preparing the patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.