Skip to content

Fix signedness warning in quantized Metal tail bounds check #4675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zcbenz merged 1 commit into from
Oct 12, 2026
Merged

Fix signedness warning in quantized Metal tail bounds check #4675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion mlx/backend/metal/kernels/quantized.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,7 +930,9 @@ METAL_FUNC void qmv_fast_impl(
// >=2-bit this is a no-op. Out-of-bounds lanes skip the qdot call entirely;
// their result[row] stays at 0 and contributes 0 to the simd_sum below.
if (aligned_end < in_vec_size) {
bool in_bounds = (aligned_end + simd_lid * values_per_thread) < in_vec_size;
bool in_bounds =
(aligned_end + static_cast<int>(simd_lid) * values_per_thread) <
in_vec_size;
if (in_bounds) {
U sum = load_vector<T, U, values_per_thread, bits>(x, x_thread);

Expand Down
Loading