Repository navigation
Fix missing stream in layer_norm and sdpa fallbacks - #4663
Merged
Merged
Conversation
zcbenz
force-pushed
the
fix-fast-fallback-streams
branch
from
October 9, 2026 10:19
35b40d1 to
e3bdd74
Compare
…ersion The fast::layer_norm fallback built one multiply without the stream, so it ran on the default stream instead of the caller's. The bool-to-additive mask conversion in scaled_dot_product_attention had the same problem with its where. Fixes ml-explore#4659.
zcbenz
force-pushed
the
fix-fast-fallback-streams
branch
from
October 10, 2026 01:15
e3bdd74 to
5ce4ec9
Compare
zcbenz
approved these changes
Oct 10, 2026
zcbenz
changed the title
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #4659 multiply(xc, rsqrt(...)) falls back to to_stream({}), where converting bool mask in SDPA faced same bug, both fixed, new c++ test to check primitive stream.