Repository navigation
Add MLX_CONV_WINOGRAD switch to disable winograd for conv2d - #4639
Merged
Merged
Conversation
zcbenz
approved these changes
Oct 8, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zcbenz in #4595:
MLX_CONV_WINOGRAD=0turns off winograd for conv2d. It's read per call, like the otherMLX_CONV_WINOGRAD_*vars.Winograd selection depends on
N x H x W, so results change with batch size. Error goes from ~2e-5 to 2.5e-4 from batch 3 up. (can see here #4595 (comment))conv.cppenvironment_variables.rstandprecision.rstpython/tests/test_conv.pythe new test fails w/o the change and passes with it, and the full suite passes on my m3 pro (939 passed)