Repository navigation
Add gather_qqmm to the ops docs - #4006
Closed
ayaangazali wants to merge 1 commit into
Closed
ayaangazali wants to merge 1 commit into
ayaangazali wants to merge 1 commit into
Conversation
Member
|
Thanks for adding this but at the moment the API is still work in progress so we would want to hide it from public APIs for a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
gather_qqmmwas added in #3757 with a full docstring, but the autosummary entry never went in, so it has no page in the ops reference. Its siblinggather_qmmis listed right above where this goes.Adding the entry generates
mlx.core.gather_qqmm.rstas expected. The only warnings on the new page are the usualtarget not found: optionalones that every function with optional arguments produces (524 of them repo wide, 8 on the neighbouringgather_qmmpage), so this does not add a new kind of warning.Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes(docs only, one line; verified by building the docs and checking the generated stub)
quick note on how i got here: freshman contributor using Claude Code to help me sweep, but i checked that #3757 touched
python/src/ops.cppwithout touchingdocs/src/python/ops.rst, confirmed the docstring has no experimental or internal wording that would explain leaving it out, and built the docs to see the page appear. if it was left out on purpose, happy to close this.