Skip to content

simple numpy helper for tests - #352

Merged
awni merged 1 commit into
ml-explore:mainfrom
dc-dc-dc:cmp-np-helper
Jan 4, 2024
Merged

awni merged 1 commit into
ml-explore:mainfrom
dc-dc-dc:cmp-np-helper

Conversation

@dc-dc-dc

@dc-dc-dc dc-dc-dc commented Jan 3, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

Added a simple helper to compare against numpy for testing. Went through some tests and converted them over to utilize it as well. This removes boiler plate code of generating arrays and converting to numpy. Now just specify the shapes and any kwargs.

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

@awni awni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants