Repository navigation
[CUDA] Pipelined QMM - #3255
Merged
Merged
[CUDA] Pipelined QMM#3255
Conversation
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a QMM kernel using Ampere pipelining, it is a lot faster than naive QMM but still has bad memory bandwidth.
DGX:
A100:
I'm afraid with the original MLX quantization format it is impossible to achieve very high memory bandwidth, but I think we should make everything work first before looking into alternatives.
This kernel is only implemented for FP16 x INT8, and I'll add support for INT4/FP4/FP8 quants in later PRs. I'll also add a fallback naive QMM kernel that supports all settings.