Repository navigation
[CUDA] Add FFT support - #3243
Merged
Merged
Conversation
zcbenz
reviewed
Mar 12, 2026
zcbenz
left a comment
zcbenz
left a comment
Member
There was a problem hiding this comment.
This is overall very nice, thanks a lot writing this!
Member
|
Can you enable the FFT tests in |
added 9 commits
March 11, 2026 18:59
Contributor
Author
|
@zcbenz Thank you for the review! I think I've addressed everything you mentioned, and tests are passing for me on my CUDA setup. Let me know if there's anything else needed. |
zcbenz
approved these changes
Mar 12, 2026
zcbenz
left a comment
zcbenz
left a comment
Member
There was a problem hiding this comment.
Just a few more nitpickings, and this looks good to me!
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This adds CUDA parity with Metal for FFT ops, as requested in #2561
The implementation uses cufft and is inspired by
nvmath-pythonwhich is referenced in that issue. I tried to make this as minimal as possible, and I verified all the tests for both python and cpp pass as expected, including the disabled-in-CI exhaustive one,test_fft_exhaustive.I only had access to an H200 with CUDA 12.4 for testing -- if there's an easy way to test on other hardware, let me know and I can try it.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes