Skip to content

Add Makefile for python related development - #308

Closed
chunyang-wen wants to merge 2 commits into
ml-explore:mainfrom
chunyang-wen:add-make-file
Closed

chunyang-wen wants to merge 2 commits into
ml-explore:mainfrom
chunyang-wen:add-make-file

Conversation

@chunyang-wen

Copy link
Copy Markdown
Contributor

Proposed changes

Add a Makefile for python related development. We do not have to type in all the commands from time to time.

Doc change preview:

image

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

@awni

awni commented Dec 29, 2023 •

Copy link
Copy Markdown
Member

I don't think we want this in the top-level directory.. . One thing that might be cool though is to default the the build to use multi-threading instead of needing to supply the environment variable. That saves many/most of the characters that I at least find hard to remember :)

To elaborate on this statement:

I don't think we want this in the top-level directory.

Different people have different tools and preferences for shortcuts / saving key strokes. Makefile is nice but nonstandard for building python packages. I encourage you to setup your situation in a way that works for you. For me bash history works really well :)

@chunyang-wen

Copy link
Copy Markdown
Contributor Author

To be honest, I am not sure where to put the file if we want it. Maybe you are right, I can setup for my dev environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants