Repository navigation
Add "edge" mode to mx.pad - #1309
Merged
Merged
Conversation
added 2 commits
August 5, 2024 17:01
awni
reviewed
Aug 6, 2024
| int destination, | ||
| StreamOrDevice s = {}); | ||
|
|
||
| enum PaddingMode { Constant, Edge }; |
Member
There was a problem hiding this comment.
Maybe use an enum class here instead of a enum
Member
There was a problem hiding this comment.
On the other hand we tend to match types from Python API to C++ API (I'm not sure that's the best choice tbh), but for the sake of consistency maybe simpler to have it be a string at the ops.h level and scope the enum to the Primitive itself.
I think (?) it also makes it easier for code binding ops.h (i.e. MLX C) to not have to add the new enum type.
E.g. like indexing for meshgrid, ord for norm.
Contributor
Author
There was a problem hiding this comment.
Sounds good! I changed it to just be a string.
awni
approved these changes
Aug 6, 2024
awni
left a comment
awni
left a comment
Member
There was a problem hiding this comment.
Looks great to me, thanks for adding that!
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1284