Skip to content

Fix noodle example #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mixonic merged 2 commits into from
Sep 21, 2016
Merged

Fix noodle example #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4b3b87
Fix noodle example
Sep 8, 2016
4de94e0
Clarity and typo
Sep 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions text/0111-element-modifier.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,15 +121,15 @@ export default Ember.ElementModifier.extend({
},

didRender() {
document.addEventListener(this.attrs.mouseover, this._logMouseover);
document.addEventListener(this.attrs.logEvent, this._logMouseover);
},

didUpdateAttrs(newAttrs, oldAttrs) {
document.removeEventListener(oldAttrs.mouseover, this._logMouseover);
document.removeEventListener(oldAttrs.logEvent, this._logMouseover);
},

willDestroyElement() {
document.removeEventListener(this.attrs.mouseover, this._logMouseover);
document.removeEventListener(this.attrs.logEvent, this._logMouseover);
}

});
Expand All @@ -156,21 +156,21 @@ const Noodle = Ember.ElementModifier.extend({
},

didRender() {
document.addEventListener(this.attrs.mouseover, this._logMouseover);
document.addEventListener(this.attrs.logEvent, this._logMouseover);
},

didUpdateAttrs(newAttrs, oldAttrs) {
document.removeEventListener(oldAttrs.mouseover, this._logMouseover);
document.removeEventListener(oldAttrs.logEvent, this._logMouseover);
},

willDestroyElement() {
document.removeEventListener(this.attrs.mouseover, this._logMouseover);
document.removeEventListener(this.attrs.logEvent, this._logMouseover);
}

});

Noodle.reopenClass({
positionalParams: ['mouseover']
positionalParams: ['logEvent']
});

export default Noodle;
Expand Down Expand Up @@ -205,7 +205,7 @@ value of an HTML element-space string for example) without namespace conflicts.
to scenario-solve event listeners across native elements, Ember component root elements, and
web components. It failed to reach a unified design that could serve all three
options. Since there does not appear to be an ideal unified solution, kicking
the challenge to use-space for a few cycles seems ideal.
the challenge to user-space for a few cycles seems ideal.

Additionally, there are other uses for element modifiers beyond event listener
attachment. These may also have specific, narrow fixes.
Expand Down