VIRTS-3499 Update to use list of strings (Link IDs) instead of list of Links#56
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
mchan143
requested review from
cmagone
and removed request for
ArtificialErmine
January 6, 2022 22:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a bug that caused the fact graph to not render when selecting an operation in the Debrief GUI and the PDF download to fail (an empty PDF is generated) when the Fact Table section is included in the PDF. The cause of the bug was a list of Links being used instead of a list of strings (Link IDs) when using
Fact.links.The proposed change will also account for Facts that have been discovered by multiple agents (more than one paw listed in
collected_by) and also, therefore, multiple commands ran to discover the same Fact. If the commands ran that discovered the same Fact are also the same, the command is only shown once in the Fact Table.Investigating this bug also led to the discovery of a different (unrelated) bug in core: apache/caldera#2432
Type of change
How Has This Been Tested?
Ran an operation against two agents that discovered the same facts and ensure the graphs were generated as expected in the debrief GUI and the Fact table in the PDF downloaded is rendered properly.
Checklist: