Skip to content

Document in-memory rate limiter tradeoff in docs/accepted-risks.md #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joryirving merged 1 commit into from
Jul 15, 2026
Merged

Document in-memory rate limiter tradeoff in docs/accepted-risks.md #624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions docs/accepted-risks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Accepted Risks

**Last updated: 2026-07-15**

## In-Memory Rate Limiting Is Per-Instance

- Rate limits on mutating endpoints (`src/lib/rate-limit.ts`) use a module-level in-memory `Map` with fixed-window tracking; limits reset on process restart and are not shared across replicas.
- The fixed-window check allows burst traffic at window boundaries (e.g., all requests allowed immediately after the window resets).
- **Mitigation:** acceptable for the current single-node internal ops tool deployment; move to a shared store (e.g., Redis) if the app is ever scaled horizontally or requires persistent limits across restarts.