Skip to content

fix: multiple empty rows in query result due to empty first row#811

Merged
michelebastione merged 3 commits into
masterfrom
fix-issue-809
Jun 20, 2025
Merged

fix: multiple empty rows in query result due to empty first row#811
michelebastione merged 3 commits into
masterfrom
fix-issue-809

Conversation

@izanhzh

@izanhzh izanhzh commented Jun 18, 2025

Copy link
Copy Markdown
Member

Fixes #809

@izanhzh izanhzh changed the title fix: query results in multiple empty lines due to the first line being empty fix: query results in multiple empty rows due to the first row being empty Jun 18, 2025
@izanhzh izanhzh changed the title fix: query results in multiple empty rows due to the first row being empty fix: multiple empty rows in query result due to empty first row Jun 18, 2025
@izanhzh izanhzh requested a review from michelebastione June 20, 2025 00:16
Signed-off-by: Michele Bastione <michele.bastione@gmail.com>
@michelebastione

Copy link
Copy Markdown
Collaborator

My bad, sorry. I'm never using the atrocious web editor again.

@michelebastione michelebastione merged commit 30040f5 into master Jun 20, 2025
3 checks passed
@michelebastione

Copy link
Copy Markdown
Collaborator

@izanhzh can you make a PR for the maintenance branch as well please? I think this should also go in there

@izanhzh izanhzh deleted the fix-issue-809 branch June 21, 2025 00:11
@izanhzh

izanhzh commented Jun 21, 2025

Copy link
Copy Markdown
Member Author

@izanhzh can you make a PR for the maintenance branch as well please? I think this should also go in there

@michelebastione
I'm really sorry, as I'm not very familiar with the maintenance workflow for GitHub branches, I just created and submitted a PR targeting the maintenance branch , but this bug fix already exists in the master branch.

Now there's a Compare & pull request button showing up on the GitHub UI. How can I get rid of it?

I found that I can click into it and then close the PR manually (I haven't done so yet), but for future reference, what is the correct way to handle similar situations?

Thanks for your understanding and help!

@izanhzh

izanhzh commented Jun 21, 2025

Copy link
Copy Markdown
Member Author

@izanhzh can you make a PR for the maintenance branch as well please? I think this should also go in there

@michelebastione I'm really sorry, as I'm not very familiar with the maintenance workflow for GitHub branches, I just created and submitted a PR targeting the maintenance branch , but this bug fix already exists in the master branch.

Now there's a Compare & pull request button showing up on the GitHub UI. How can I get rid of it?

I found that I can click into it and then close the PR manually (I haven't done so yet), but for future reference, what is the correct way to handle similar situations?

Thanks for your understanding and help!

After some time, now Compare & pull request button no longer showing up on the GitHub UI

@michelebastione

Copy link
Copy Markdown
Collaborator

Honestly I'm not sure why that occurred, let's pay attention in case it happens again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

读取Excel,当第一行为隐藏的空行时,读取结果会变成两行空行

2 participants