This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Comparison operators added on Version object.#5
Open
tonioo wants to merge 24 commits into
Open
Conversation
|
@mindsnacks what do you think? |
Python 3 support
The validation method now checks the following: * If version string has too many components (1.2.3.4.5 with only 3 components allowed); * If any component is not numeric (1.x is not supported due to storage implementation); * If any component is too big (one can't save number greater than 255 with 8 bits, for example). Raising ValidationError in validate() allows us to avoid ValueError later.
Implement validation for the field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A little but usefull improvement.