Repository navigation
fix(lib): build on nightly-2026-09-27, and find a glob nested in a use list - #10
Merged
Merged
Conversation
…e list rust-lang/rust#162630 (merged 2026-09-14) deleted `EmissionGuarantee` and made `Diagnostic<'a>` non-generic, so the policy diagnostic now implements the plain trait. HIR also stopped lowering `use a::{b, c::*}` to one item per element. The list is now one `ItemKind::Use(UseTree)` whose `UseKind::Nested` holds the elements, so matching only a top-level `UseKind::Glob` would silently stop flagging a glob inside a list. The wildcard pass now walks the tree and reports each glob at its own path. The product-core fixture gains that case. The supplied-toolchain-identity check moves to 2026-09-26, the newest date that compiles against the new API and still differs from the rolling default.
mikeslade
added a commit
that referenced
this pull request
Sep 27, 2026
…iver for the removed --env-set (#11) nix flake update moved only crane; #10 already carried nixpkgs and rust-overlay to today's snapshot, so the toolchain stays nightly-2026-09-27. cargo update moves 35 packages, among them dylint_linting 6.0.2 -> 6.1.0, and the flake's dylint tools follow. rust-lang/rust#161831 removed the unstable --env-set flag on 2026-08-31. dylint >= 6.0.3 passes it on every lint run, so its driver fails on any newer nightly with "Unrecognized option: 'env-set'" (trailofbits/dylint#2078, still open). The flake now patches the driver source to stop passing the flag, restoring the 6.0.2 behaviour, with --replace-fail so the upstream fix shows up here as a build failure. Also fixes one clippy redundant_closure so clippy is clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nightly-2026-09-27 does not compile this library. Two upstream changes:
GinDiag<'a, G>rust-lang/rust#162630 (merged 2026-09-14) deletedrustc_errors::EmissionGuarantee;Diagnostic<'a>andDiag<'a>lost theGparameter.RustLintsPolicyDiagnow implements the plain trait.use a::{b, c::*}into one item per element. It is oneItemKind::Use(UseTree)withUseKind::Nested { items }. The oldmatches!(item.kind, ItemKind::Use(_, UseKind::Glob))stopped compiling, and a plain port to the new shape would only catch top-level globs.check_wildcard_importnow recurses and reports each glob at its own path span.Also:
nix flake update rust-overlay nixpkgsso the rolling default resolves the new nightly, andsupplied-toolchain-identitymoves from 2026-08-26 (no longer compiles) to 2026-09-26: new enough for the new API, and still different from the rolling default, which is what that check is asserting.Needed by techzenlabs/benefits-platform's move to nightly-2026-09-27.
How verified
nix flake checknix develop -c cargo test --releasenix develop -c scripts/check-blocking-in-async-fixture.shcargo dylint --all -- --workspace(README command)product-core/src/lib.rs:7:1(use sqlx::*) and the newlib.rs:24:21(deep::*insideuse nested::{Named, deep::*})cargo fmt --checkGATE_AT_COMMIT=2ec820e5e23465de0216b1e9561ed561f5c07686