fix(flex): correct one-minute flex calc (fall back to PlanHours/PaiedOutFlex when *InSeconds unset)

[renemadsen]

Problem

With UseOneMinuteIntervals = true, the flex calculation is wrong. ApplyNettoFlexChainSecondPrecision subtracts PlanHoursInSeconds and PaiedOutFlexInSeconds, but those int second-columns are never populated in the punch-clock/planner/payout flows (only the double PlanHours / PaiedOutFlex are). They sit at 0, so:

• Flex = full netto worked instead of netto − planned. Cumulative SumFlexEnd compounds it (two days 7.67h + 6.33h displayed flex 14.00 instead of 0.67h / 1.33h).
• A flex payout subtracts 0, so SumFlexEnd never decreases.

The flag-OFF path is correct because it uses the double PlanHours / PaiedOutFlex directly.

Fix (forward-only, C# only)

In PlanRegistrationHelper.ApplyNettoFlexChainSecondPrecision, fall back to the populated double when the seconds column is 0:

planHoursSeconds    = PlanHoursInSeconds    != 0 ? PlanHoursInSeconds    : (int)Math.Round(PlanHours    * 3600)
paiedOutFlexSeconds = PaiedOutFlexInSeconds != 0 ? PaiedOutFlexInSeconds : (int)Math.Round(PaiedOutFlex * 3600)

Handover/absence flows that legitimately populate the seconds columns are preserved (the != 0 guard uses them verbatim).

Tests

Two new regression tests (Flex_FlagOn_PlanHoursInSecondsZero_FallsBackToPlanHours, SumFlex_FlagOn_PaiedOutFlexInSecondsZero_FallsBackToPaiedOutFlex) — both fail on the old code, pass on the fix. The existing FlagOn test masked the bug by pre-setting PlanHoursInSeconds.

Follow-up

Existing already-stored wrong Flex/SumFlexEnd rows for UseOneMinuteIntervals customers are repaired separately via a targeted script (forward-only on the data).

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Fixes incorrect flex and cumulative flex (SumFlexEnd) calculations when UseOneMinuteIntervals = true by ensuring the second-precision flex chain uses the populated double fields (PlanHours, PaiedOutFlex) when their corresponding *InSeconds columns are left as 0 by punch-clock/planner/payout writers.

Changes:

• Update ApplyNettoFlexChainSecondPrecision to fall back from PlanHoursInSeconds/PaiedOutFlexInSeconds to rounded PlanHours * 3600 / PaiedOutFlex * 3600 when the seconds columns are 0.
• Add two regression tests to cover the “seconds columns unset” production scenario for both planned hours and paid-out flex.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
eFormAPI/Plugins/TimePlanning.Pn/TimePlanning.Pn/Infrastructure/Helpers/PlanRegistrationHelper.cs	Adds guarded fallback seconds derivation to keep flag-on flex chain correct when seconds columns are not populated.
eFormAPI/Plugins/TimePlanning.Pn/TimePlanning.Pn.Test/PlanRegistrationHelperTests.cs	Adds regression tests verifying correct fallback behavior for plan hours and paid-out flex in the one-minute chain.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.