fix gradle setup and .gitignore#1
Merged
caitlinrussell merged 1 commit intomicrosoftgraph:masterfrom Nov 29, 2017
davidmoten:gradle-setup-gitignore
Merged
fix gradle setup and .gitignore#1caitlinrussell merged 1 commit intomicrosoftgraph:masterfrom davidmoten:gradle-setup-gitignore
caitlinrussell merged 1 commit intomicrosoftgraph:masterfrom
davidmoten:gradle-setup-gitignore
Conversation
86961e3 to
631c483
Compare
Contributor
Author
|
Yikes, a major rebase job is needed now. I'll sort it. |
…ion to .gitignore, remove existing metadata files and bin files
Contributor
Author
|
I've rebased and removed my fixes to test classes, constraining only to setup stuff like gradlew, .gitignore and removing ide metadata etc. @Cbales can you review this and merge please to avoid more rebase pain? As part of review what version of gradle do you want to use? |
|
Thanks so much for the cleanup! I hadn't looked into the included files yet and definitely should have before anyone cloned it. I also did a rebase myself to remove another file, so after we merge this in, you'll want to clone again as well I believe. |
caitlinrussell
approved these changes
Nov 29, 2017
Contributor
Author
|
Beaut. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hiya
First pull request being for changes just so I could build and import to IDE.
Oh to save you some time perhaps (I know you work across a lot of languages!), to import the project into eclipse:
and import as eclipse project as usual.