feat: bot names and avatars#3071
Merged
Merged
Conversation
sets up a proivder model for getting Bot based data refactor to create a base class for stateful clients creates a new component for rendering chat avaatars that can handle bots fix: stop creating two instances of the notification client closes #3068 fix: remove contenteditable attribute from emjoi html closes #3060
This was
linked to
issues
Feb 23, 2024
plasne
reviewed
Feb 23, 2024
plasne
reviewed
Feb 23, 2024
plasne
reviewed
Feb 23, 2024
plasne
left a comment
plasne
left a comment
There was a problem hiding this comment.
I have a few comments, but I will test this out this afternoon as well and see if I find anything.
6 tasks
|
Dunno if you want to do this or not, but in Teams, all bots seem to have a hexagon, not a circle... 
|
|
None of my 1:1 chats with bots have an icon in the top... 
From Teams... 
|
plasne
reviewed
Feb 23, 2024
plasne
left a comment
plasne
left a comment
There was a problem hiding this comment.
I would like to see the ChatHeader have the bot name when it is a 1:1 chat with a bot like Teams.
Member
Author
That's in the nice to have category, tracking this as #3084 |
Member
Author
That makes sense to me, I suspect we'll have to do something here to infer the avatar like exposing a map keyed on the chatId returning a list of Bots on the state emitted by BotInfoClient as I'm not sure that we can rely on the installedApps collection to reflect the Bots that are active in the conversation. |
|
🚀 New react-contoso sample application deployed here |
Member
Author
|
|
🚀 New react-contoso sample application deployed here |
This was referenced Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2947
Closes #3060
Closes #3068
PR Type
Description of the changes
sets up a React Context + Provider model for getting Bot based data via a shared Stateful Client
refactor to create a base class for stateful clients
creates a new component for rendering chat avatars that can handle bots
stop creating two instances of the notification client
remove contenteditable attribute from emjoi html
PR checklist
yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense)Other information