Repository navigation
Stop restarting processes if they exit more than 10 times in a minute - #831
Closed
Blue (OneBlue) wants to merge 1 commit into
Closed
Blue (OneBlue) wants to merge 1 commit into
Blue (OneBlue) wants to merge 1 commit into
Conversation
Blue (OneBlue)
requested review from
Ben Hillis (benhillis) and
Hideyuki Nagase (hideyukn88)
September 21, 2022 01:29
Contributor
|
Blue (@OneBlue), do we see any case of repeated crash of weston (or any process launched by WSLGd) on reasonable recent version? As you might be aware of the internal email thread the high CPU usage on arm64 is now understood, but if there is any instance of such repeated process crash, we should reach out to collect core dumps to fix the root case, rather throttling down to hide the issue? |
Hideyuki Nagase (hideyukn88)
force-pushed
the
throttle-crashes
branch
from
July 10, 2023 19:04
997f018 to
b582092
Compare
Contributor
|
abandon this PR and recreated as #1082 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds logic to
wslgd::ProcessMonitor::Runto keep track of how often processes exit and stops restarting processes that exit more than 10 times in 60 seconds.Tested by running
pkill weston10 times in the system distro, stderr.txt shows:This change should help mitigate microsoft/WSL#6982 , since we've seen situations where wslg processes would crash and be restarted in a loop (although I don't think 100% of the high cpu usage issues are caused by wslg, I think some are)