Skip to content

Clarify blocked and ready-for-review lifecycle states - #915

Merged
Nikola Metulev (nmetulev) merged 3 commits into
mainfrom
nmetulev-sandbox-feedback-investigation
Sep 21, 2026
Merged

Nikola Metulev (nmetulev) merged 3 commits into
mainfrom
nmetulev-sandbox-feedback-investigation

Conversation

@nmetulev

@nmetulev Nikola Metulev (nmetulev) commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

Description

Make lifecycle labels describe whether the agent has finished its work, rather than whether a reviewer has responded:

  • Reserve agent-blocked for feedback or CI the agent cannot finish without help, or missing author input.
  • Use ready-for-review when agent work and technical checks are complete, including while awaiting re-review of addressed feedback.
  • Use labels instead of automated lifecycle/status comments. Keep operational details in session checkpoints; necessary review-feedback replies remain required.
  • Keep pending approvals distinct without dismissing a human changes-request review or implying permission to merge.
  • Continue configured follow-through while requested re-review is pending.

The initial independent assessment and ordinary validation/CI waits remain preparation work.

Usage Example

Illustrative workflow decisions:

Situation Lifecycle label
Feedback addressed and checks green; reviewer has not reassessed yet ready-for-review
Agent is fixing a finding or waiting for required CI agent-preparing
Agent cannot address feedback/fix CI with available access, or needs an author decision agent-blocked

ready-for-review does not override GitHub's approval or merge requirements. Status belongs in the label, not a recurring PR progress comment.

Related Issue

N/A — requested contributor-workflow policy clarification.

Type of Change

  • 📝 Documentation

Checklist

  • Validated the contributor skill's frontmatter, relative links, Markdown fences, and label references locally on Windows.
  • git diff --check passes.

Screenshots / Demo

N/A — contributor instructions only; no application or CLI runtime changes.

Additional Notes

The repository label was already renamed from agent-ready-for-review to ready-for-review with explicit authorization; existing memberships were preserved. Its descriptions and the active agents' instructions were updated to match.

No full NativeAOT build was run for this contributor Markdown-only change.

AI Description

This section is auto-generated by AI when the PR is opened or updated. To opt out, delete this entire section including the marker comments.

Treat addressed feedback awaiting re-review as ready, reserve agent-blocked for work requiring help, and retain approval and merge safeguards.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@nmetulev Nikola Metulev (nmetulev) added the agent-preparing Agent is addressing feedback or completing required validation and CI label Sep 21, 2026
Keep operational checkpoints in session state and preserve necessary review-feedback replies without posting progress comments.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The documentation is internally consistent and has no unresolved issues.

Review effort: Balanced
Findings: None

What changed in this PR

Clarifies PR lifecycle labels so they reflect agent progress independently of pending human approval.

Changes:

  • Defines when to use agent-preparing, agent-blocked, and ready-for-review.
  • Keeps re-review status visible while continuing configured follow-through.
File Description
.github/​skills/​pr-lifecycle/​SKILL.md Updates lifecycle and re-review guidance.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@nmetulev
Nikola Metulev (nmetulev) marked this pull request as ready for review September 21, 2026 23:38
@nmetulev
Nikola Metulev (nmetulev) merged commit 32fd253 into main Sep 21, 2026
13 checks passed
@nmetulev
Nikola Metulev (nmetulev) deleted the nmetulev-sandbox-feedback-investigation branch September 21, 2026 23:39
@nmetulev Nikola Metulev (nmetulev) removed the agent-preparing Agent is addressing feedback or completing required validation and CI label Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants