Repository navigation
Correct dotnet output-draining documentation - #907
Merged
Merged
Conversation
Clarify that .NET 10 WaitForExitAsync already drains redirected output and document normal callback completion and cancellation limits. No runtime behavior changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Nikola Metulev (nmetulev)
deleted the
nmetulev-dotnet-output-draining
branch
September 21, 2026 21:19
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation accurately matches the .NET 10 runtime implementation.
Review effort: Balanced
Findings: None
What changed in this PR
Corrects documentation for .NET 10 process-output draining; no runtime behavior changes.
Changes:
- Documents callback completion and cancellation limitations.
- Corrects the misleading synchronous-wait comment.
| File | Description |
|---|---|
IDotNetService.cs |
Clarifies output-reader callback guarantees. |
DotNetService.cs |
Corrects WaitForExitAsync commentary. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Sep 21, 2026
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Correct the misleading comment that led to #898: on .NET 10,
WaitForExitAsyncalready waits for both redirected output readers and their synchronous callbacks to finish. Clarify the streaming and callback-enabled buffered API documentation, including cancellation and downstream asynchronous-work limitations.Comments/XML documentation only. Executable statements, including the existing redundant synchronous wait, are unchanged.
Usage Example
N/A — no command, flag, or API behavior changes.
Related Issue
Closes #898. The reported race was inferred from code, not reproduced; the runtime implementation contradicts its premise.
Type of Change
Checklist
git diff --checkpassed.Screenshots / Demo
N/A.
Additional Notes
The .NET 10 runtime implementation awaits both output readers through
WaitUntilOutputEOF.No builds or tests were run for this documentation-only change.