Repository navigation
Variable-length path-based string cleanup - #165
Merged
Merged
Conversation
Jon Wiswall (jonwis)
requested review from
Chris Guzak (ChrisGuzak) and
Duncan Horn (dunhor)
December 19, 2020 22:57
Chris Guzak (ChrisGuzak)
approved these changes
Dec 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wil::GetModuleFileName[Ex]Wnow uses the "adapt fixed buffer to variable length" helper method,which automatically does the retry-in-a-loop and does the "trim to the first null character" work so
that
result.length()matcheswcslen(result.c_str()). Fixes #163 .Also fixes
wil::QueryFullProcessImageNameWto default to doubling the buffer rather than increment-by-onewhich prevents spinning when paths are > default-stack-buffer-size. Fixes #3 .
And fixes the incorrectly used macro in documentation. Fixes #151
Verified by adding new tests and seeing them work.