Repository navigation
rdp shell: fix overactive assert at launch_desktop_shell_process - #139
Merged
Hideyuki Nagase (hideyukn88) merged 1 commit intoMar 8, 2023
Conversation
Hideyuki Nagase (hideyukn88)
requested review from
brdegeer and
Steve Pronovost (spronovo)
March 8, 2023 22:41
brdegeer
approved these changes
Mar 8, 2023
Hideyuki Nagase (hideyukn88)
deleted the
fix_rdprail_shell_crash_at_launch_shell_process
branch
March 8, 2023 23:32
Timo Hendricks (thendricks0)
pushed a commit
to thendricks0/weston-mirror
that referenced
this pull request
Nov 17, 2025
…rosoft#139) Co-authored-by: Hideyuki Nagase <hideyukn@HIDEYUKN-SB3>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to address the issue found at microsoft/wslg#1000 (comment), and this is the regression introduced at #128. Prior to this PR, shell process is launched once at shell initialization, but after that PR, shell process launch is deferred until the first surface reported to shell. When multiple surfaces are reported without processing Wayland idle event, it's possible multiple of event can be queued, and the assertion (which is converted to if) to be triggered at second event trigger.