Optimize the whisper base demo - #94
Merged
Dwayne Robinson (fdwr) merged 3 commits intoSep 23, 2025
Merged
Conversation
Dwayne Robinson (fdwr)
left a comment
Dwayne Robinson (fdwr)
left a comment
Collaborator
There was a problem hiding this comment.
Minor nit, else seems fine to me. Delegating correctness of cached tensors (and whether to relax deviceType for NPU) to Wanming before continuing⏳. Thanks Bin.
Wanming Lin (Honry)
approved these changes
Sep 19, 2025
Wanming Lin (Honry)
left a comment
Wanming Lin (Honry)
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks！
Contributor
Author
|
Since the fix is included in the latest dev version. Set up ORT version to dev. Please take another look, thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize the whisper base demo:
testuntil the fix is included in the latest dev version.Wanming Lin (@Honry) Dwayne Robinson (@fdwr) PTAL. cc\ Belem Zhang (@ibelem) Thanks.