Align expert reviewer verdicts with safe outputs - #16381
Merged
Jakub Jareš (nohwnd) merged 1 commit intoAug 19, 2026
Merged
Conversation
The delegated reviewer still recommends APPROVE while the workflow rejects it, causing deterministic safe_outputs failures. Return COMMENT for clean reviews. 🤖 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the expert reviewer agent guidance to match the repository workflow’s enforced safe_outputs policy by removing APPROVE as an allowed verdict, preventing delegated reviews from returning disallowed outputs.
Changes:
- Removes
APPROVEfrom the documented set of allowed review verdicts. - Adds explicit guidance that automated reviewers must only return
COMMENTorREQUEST_CHANGES. - Clarifies the “no findings” case as
COMMENT (NO FINDINGS)while keeping approval as a human maintainer action.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expert reviewer agent still tells delegated reviews to return
APPROVE, while the workflow only permitsCOMMENTandREQUEST_CHANGES. This made thesafe_outputsjob fail twice on #16033.Clean reviews now return
COMMENT, matching the enforced workflow policy.🤖