Show a quickpick for changing display language - #69570
Conversation
|
Rachel Macfarlane (@RMacfarlane) thanks a lot for the PR. |
|
I looked over it and I have a suggestions: I think we should indicate whether the corresponding language pack is available locally. If not it might even be cool to install it. Otherwise the expierence might not be nice when selecting a LP that is not installed. |
|
Ah, thanks! I had misread the code for |
|
Rachel Macfarlane (@RMacfarlane) have you updated the PR. I think I don't see the new code changes. |
00daba5 to
6e79d4e
Compare
|
Dirk Bäumer (@dbaeumer) it should be updated now, I just rebased against master |
|
Rachel Macfarlane (@RMacfarlane) LGTM. Feel free to merge in. |
|
Dirk Bäumer (@dbaeumer) Thanks for reviewing! I pushed one more change to show a confirmation dialog before restarting, based on feedback when demoing to the Redmond team. I'll go ahead and merge since that addition is very simple. |
While verifying issues I had to change my display language a couple of times, and I think the experience for it could be bit better.
Instead of opening the
locale.jsonfile, this PR uses the localization service to get the list of available languages and display it in a quick pick. The current language is selected by default, and the placeholder text explains that VS Code will restart on selection. When something is selected, thelocale.jsonfile is written to as before and VS Code gets restarted.When running out of sources I don't ever see the UI language change - I haven't dug into how nls gets loaded so I'm not sure if that's expected or not. But I do see that the
locale.jsonfile is updated correctly.This fixes #22758
Let me know if you think this is a good change. Thanks!