Skip to content

chore: bump electron 42 header version for msvc compatibility - #318587

Merged
Robo (deepak1556) merged 1 commit into
mainfrom
robo/rm_windows_build_workaround
May 28, 2026
Merged

Robo (deepak1556) merged 1 commit into
mainfrom
robo/rm_windows_build_workaround

Conversation

@deepak1556

Copy link
Copy Markdown
Collaborator

Followup to #316661

Bump only npm target to 42.3.0 that contains electron/electron@0e1fe29

The current preinstall header patching doesn't work for root node_modules due to order of lifecycle script invocation.

@deepak1556 Robo (deepak1556) added this to the 1.123.0 milestone May 27, 2026
@deepak1556 Robo (deepak1556) self-assigned this May 27, 2026
Copilot AI review requested due to automatic review settings May 27, 2026 16:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Follow-up to the Electron 42 update (PR #316661). Instead of preinstall-time patching of the cppgc/heap.h header (which didn't run early enough for root node_modules), this PR bumps the Electron headers npm target to 42.3.0, which already contains the MSVC-compatible upstream fix, and removes the custom header patching machinery.

Changes:

  • Bump .npmrc headers target from 42.2.0 to 42.3.0 and hardcode the Electron runtime version in build/lib/electron.ts to 42.2.0.
  • Remove the local cppgc/heap.h custom header and the related explanatory comment in build/npm/preinstall.ts.
  • Drop the now-unnecessary explicit node build/npm/preinstall.ts invocation from all Windows CI pipelines and the PR workflow; bump build/.cachesalt.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.npmrc Bumps Electron headers target to 42.3.0.
build/lib/electron.ts Decouples headers target from runtime by hardcoding electronVersion = '42.2.0'.
build/npm/preinstall.ts Drops the comment referencing the removed cppgc/heap.h patch.
build/npm/gyp/custom-headers/cppgc/heap.h Deletes the custom MSVC-compatible header now obsoleted by 42.3.0.
build/azure-pipelines/win32/steps/product-build-win32-compile.yml Removes explicit pre-install header-patch step.
build/azure-pipelines/win32/sdl-scan-win32.yml Removes explicit pre-install header-patch step.
build/azure-pipelines/win32/product-build-win32-node-modules.yml Removes explicit pre-install header-patch step.
.github/workflows/pr-node-modules.yml Removes explicit pre-install header-patch step.
build/.cachesalt Bumps cache salt to invalidate caches built against the prior header set.

Comment thread build/lib/electron.ts Resolved
@deepak1556
Robo (deepak1556) merged commit 843588f into main May 28, 2026
64 of 68 checks passed
@deepak1556
Robo (deepak1556) deleted the robo/rm_windows_build_workaround branch May 28, 2026 01:12
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Jul 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants