Repository navigation
Update xterm.js to 6.1.0-beta.220 - #317936
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the VS Code terminal’s xterm.js dependency set to newer 6.1.0 beta builds (and matching addon betas), picking up upstream fixes referenced in #317740, and adjusts the clipboard addon integration for the updated addon API surface.
Changes:
- Bump
@xterm/xtermto6.1.0-beta.220and update related@xterm/*addon versions across root/remote/web packages and lockfiles. - Adjust the clipboard addon handler typings in
XtermTerminalto match the updated@xterm/addon-clipboardtype exports.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts | Updates clipboard addon import and handler callback parameter types to align with the updated addon typings. |
| package.json | Bumps xterm.js and addons to the newer beta versions used by desktop builds. |
| package-lock.json | Lockfile refresh for updated xterm.js/addons and related dependency graph adjustments. |
| remote/package.json | Bumps xterm.js, addons, and headless xterm for remote (REH) builds. |
| remote/package-lock.json | Lockfile refresh for remote package dependency updates. |
| remote/web/package.json | Bumps xterm.js and addons for web-remote packaging. |
| remote/web/package-lock.json | Lockfile refresh for remote web package dependency updates. |
Copilot's findings
Files not reviewed (2)
- remote/package-lock.json: Language not supported
- remote/web/package-lock.json: Language not supported
- Files reviewed: 4/7 changed files
- Comments generated: 0
| } | ||
| this._clipboardAddon = this._instantiationService.createInstance(ClipboardAddon, undefined, { | ||
| async readText(type: ClipboardSelectionType): Promise<string> { | ||
| async readText(type: string): Promise<string> { |
There was a problem hiding this comment.
Why? Did the type signature change?
There was a problem hiding this comment.
Api shape changed.
Also what's wrong with #317927 ? Why make a new PR?
Same reason. Thanks for the interest
|
Also what's wrong with #317927 ? Why make a new PR? |
Pull request was closed
|
Nicholas Lim (@niclimcy) there's a CI check that bans any 3p changes to dependencies to help avoid supply chain attacks: 
|
|
when will this land in stable version？really need this fix |
|
YuTengjing (@tjx666) looks like 1.222 was released yesterday, so probably in ~6 days |
Resolves: #317740