check for valid input in search editor

[Andrea Mah (andreamah)]

Otherwise, you get an infinite loading bar animation. Adopting same fix as in search view.

fixes #225315

[Karl Horky (karlhorky)]

Andrea Mah (@andreamah) and reviewers thanks for the PR and review!

I'm assuming this will be out in the next recovery release?

• July 2024 Recovery 2

[Andrea Mah (andreamah)]

It will be out on the August 2024 release, since it's not urgent enough to be on the recovery. However, it will be on tomorrow's VS Code Insiders.

[Karl Horky (karlhorky)]

I just checked the new release August 2024 (version 1.93) and the bug from #225315 still appears to be there:

Kapture.2024-09-06.at.10.09.07.mp4

I didn't see a mention in the release notes - has this been reverted or not pulled in to the August 2024 release?

[Andrea Mah (andreamah)]

Hmm. I see this on the latest version:

Are you sure you're on the latest version? and which os?

[Karl Horky (karlhorky)]

Interesting, my version + system details:

Version: 1.93.0
Commit: 4849ca9bdf9666755eb463db297b69e5385090e3
Date: 2024-09-04T13:02:38.431Z (2 days ago)
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Darwin arm64 23.6.0

macOS Sononma 14.6.1 (23G93)
Chip: Apple M1

[Karl Horky (karlhorky)]

To be clear, the infinite loading bar doesn't appear right away. If I just paste pageTitle: '([^']+)',\n.+) into the field, then there is no bar, only the "Invalid regular expression" error like in your screenshot.

It's when I move from a valid regex to an invalid one, repro steps:

1. Paste in pageTitle: '([^']+)',\n.+) - infinite loading bar not reproduced yet
2. Press backspace 1 time - infinite loading bar not reproduced yet
3. Add back ) - infinite loading bar reproduced

Maybe also needs a few cycles of the above steps, if the first time doesn't work.

[Karl Horky (karlhorky)]

If it looks like a bit of work to track down, we could also consider reopening #225315 .

[Andrea Mah (andreamah)]

Reopened the issue - will see if i can run into the issue a bit later