enable find in the debug console

[Megan Rogge (meganrogge)]

fixes #4338

Follow up work will be:

• making it screen reader friendly: find in trees is not screen reader accessible #225157
• it looks jumpy when I search, can that be fixed?

find.mov

[Connor Peet (connor4312)]

lgtm

[Connor Peet (connor4312)]

This gets rid of the filter entirely in the view now, right? I'm not sure that's something we'd want to just remove without giving some replacement action in its place, even if it's just an explicit button that opens the find widget

[Megan Rogge (meganrogge)]

fixed

[Megan Rogge (meganrogge)]

I just realized that currently, tree find is limited - it can only highlight matches found in the input.

However, similar to the filter widget, it can filter results based on what is found in the output.

Highlighting matches in the output might be possible when #212077 is accomplished.

Thus, by default, I think we should use filter to keep the behavior the same as before with the option to toggle to find.

[roblourens]

I wonder about removing the filter box entirely, when the replacement doesn't support all the same features (negative patterns). Any plan to support that in the tree find widget?

[burekas7]

Thanks.
I prefer that both features remain, the 'find' and the 'filter'

[Megan Rogge (meganrogge)]

Ok, sounds good. I'll bring back the filter and will go with the default tree find keybinding, ctrlCmd+alt+f, vs ctrlCmd+f then for this feature.

[here~ (seryte)]

I hope it works the same as find in terminal

[Megan Rogge (meganrogge)]

It does not atm as mentioned on the issue. That is the ultimate goal though