Fix race condition with restoration of problems when closing a file - #183271
Merged
Megan Rogge (meganrogge) merged 2 commits intoDec 19, 2023
Merged
Conversation
Fixes microsoft#47386 This sets the `flushOnListenerRemove` option to true for the call to Event.debounce. Without this, some `onMarkerChanged` events can get dropped -- specifically, when an event gets fired more than 100ms after first listening, in which case the 600ms cleanup setTimeout fires while the 500ms debounce timeout is still pending.
Megan Rogge (meganrogge)
assigned
Megan Rogge (meganrogge) and unassigned
Matt Bierner (mjbvz)
Megan Rogge (meganrogge)
approved these changes
Nov 15, 2023
Megan Rogge (meganrogge)
left a comment
Megan Rogge (meganrogge)
left a comment
Collaborator
There was a problem hiding this comment.
Thank you!
Raymond Zhao (rzhao271)
approved these changes
Dec 19, 2023
Logan Ramos (lramos15)
approved these changes
Dec 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47386
This sets the flushOnListenerRemove option to true for the call to Event.debounce. Without this, some
onMarkerChangedevents can get dropped -- specifically, when an event gets fired more than 100ms after first listening, in which case the 600ms cleanup setTimeout fires while the 500ms debounce timeout is still pending.Because of the race condition, the fix for #116760 applied at df97bc3 would only work intermittently.
cc Megan Rogge (@meganrogge) (looks like you were assigned to my previous attempt to fix this at #183172)