Skip to content

add generic marker sequence and markers/decorations for problems - #152671

Merged
Megan Rogge (meganrogge) merged 31 commits into
mainfrom
merogge/problem-marker
Jun 23, 2022
Merged

add generic marker sequence and markers/decorations for problems#152671
Megan Rogge (meganrogge) merged 31 commits into
mainfrom
merogge/problem-marker

Conversation

@meganrogge

@meganrogge Megan Rogge (meganrogge) commented Jun 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR fixes #151769 and fixes #152391

@vscodenpa VS Code Bot (vscodenpa) added this to the June 2022 milestone Jun 20, 2022
@meganrogge
Megan Rogge (meganrogge) marked this pull request as draft June 20, 2022 19:49
@meganrogge
Megan Rogge (meganrogge) marked this pull request as ready for review June 20, 2022 20:43
@meganrogge
Megan Rogge (meganrogge) marked this pull request as draft June 20, 2022 22:11
@meganrogge

Megan Rogge (meganrogge) commented Jun 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

working well except for the first run of the task

@Tyriar

Daniel Imms (Tyriar) commented Jun 23, 2022

Copy link
Copy Markdown
Contributor

[4:09:59 PM] File change detected. Starting incremental compilation... matches but [4:07:41 PM] Starting compilation in watch mode... does not

Fixed in #152966, #152967

@Tyriar

Daniel Imms (Tyriar) commented Jun 23, 2022

Copy link
Copy Markdown
Contributor

It looks a little off how the decoration shows up before any problems do:

image

Not sure there's a nice way to workaround that if we want to use the SetMark sequence.

@Tyriar

Daniel Imms (Tyriar) commented Jun 23, 2022

Copy link
Copy Markdown
Contributor

It ended up in the wrong spot on my first test of the https://github.com/lunapaint/tga-codec build task:

image

@Tyriar

Daniel Imms (Tyriar) commented Jun 23, 2022

Copy link
Copy Markdown
Contributor

Weird things happen on resize in Windows, probably because of reprinting:

Recording 2022-06-23 at 05 01 33

Above is also 2 decorations on top of one another.

Tyriar
Daniel Imms (Tyriar) suggested changes Jun 23, 2022
View reviewed changes
Comment thread src/vs/platform/terminal/common/xterm/shellIntegrationAddon.ts Resolved
Comment thread src/vs/platform/terminal/common/xterm/shellIntegrationAddon.ts Resolved
Comment thread src/vs/platform/terminal/common/terminalProcess.ts Resolved
Comment thread src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts Resolved
Comment thread src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts Resolved
Comment thread src/vs/platform/terminal/common/terminalProcess.ts Resolved
Comment thread src/vs/workbench/contrib/terminal/browser/terminalEscapSequences.ts Resolved
Comment thread src/vs/workbench/contrib/terminal/browser/xterm/decorationAddon.ts Resolved
Comment thread src/vs/workbench/contrib/terminal/browser/xterm/decorationAddon.ts Resolved
Megan Rogge (meganrogge) and others added 3 commits June 23, 2022 09:44
@meganrogge @Tyriar
Update src/vs/platform/terminal/common/xterm/shellIntegrationAddon.ts
b82fe91 
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@meganrogge @Tyriar
Update src/vs/workbench/contrib/terminal/browser/xterm/decorationAddo…
7a0271e 
…n.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@meganrogge
add e to file name
be9e602
@Tyriar Daniel Imms (Tyriar) mentioned this pull request Jun 23, 2022
Closed
@meganrogge

Megan Rogge (meganrogge) commented Jun 23, 2022

Copy link
Copy Markdown
Collaborator Author

It looks a little off how the decoration shows up before any problems do:

image

Not sure there's a nice way to workaround that if we want to use the SetMark sequence.

we could add a delay before showing it?

@meganrogge

Megan Rogge (meganrogge) commented Jun 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

It ended up in the wrong spot on my first test of the https://github.com/lunapaint/tga-codec build task:

image

It ended up in the wrong spot on my first test of the https://github.com/lunapaint/tga-codec build task:

did that happen on first compilation?

yep that's an issue i'm aware of and reproes w any task for the first compilation - doesn't match here for xterm.js. likely the case for luna paint as well
Screen Shot 2022-06-23 at 10 46 47 AM
so is an issue with the $tsc-watch problem matcher
Screen Shot 2022-06-23 at 10 48 47 AM

@meganrogge
h
c10717a 
Merge branch 'main' into merogge/problem-marker
@meganrogge
Megan Rogge (meganrogge) enabled auto-merge (squash) June 23, 2022 22:29
@meganrogge
Megan Rogge (meganrogge) deleted the merogge/problem-marker branch June 23, 2022 22:36
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@Tyriar Daniel Imms (Tyriar) Tyriar approved these changes
@mjbvz Matt Bierner (mjbvz) mjbvz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@meganrogge Megan Rogge (meganrogge)

Labels

None yet

Projects

None yet

Milestone

June 2022

Development

Successfully merging this pull request may close these issues.

add markers for problem matchers in tasks with shell integration Support generic scroll bar mark sequences (OSC 1337 ; SetMark)

4 participants

@meganrogge @Tyriar @mjbvz @vscodenpa