Repository navigation
Enable SCM Views to move to panel #90461
Description
Tracking item to enable SCM views to move using new infra. It looks like SCM has some hurdles when moving to the panel. it registers views as they come in but the views have relationships kind of like extensions viewlet. wondering if we need a way to say "this container is a unit and everything must move together"
Activity
joaomoreno commentedon Feb 12, 2020
SCM is definitely a strange beast. Its UX baggage (one view controls others' visibilities) makes it hard to reason about when we consider moving views around.
sandy081 commentedon Feb 12, 2020
Yeah same boat as in extension viewlet views. I decided not to move extension because they are tightly associated to the search functionality. Same applies for SCM too.
sbatten commentedon Feb 12, 2020
João Moreno (@joaomoreno) due to the fact that other views can be contributed to the scm viewlet and they could be moved, I think we should explore getting scm views to be movable too.
joaomoreno commentedon Feb 28, 2020
After discussing this with Sandeep Somavarapu (@sandy081) we've come up with an idea:
What do you think SteVen Batten (@sbatten)? We could act on step 1 beginning of April for Insiers, once I'm back, and see what the feedback is.
9 remaining items
sandy081 commentedon Apr 6, 2020
I see the point from SteVen Batten (@sbatten). But SCM changes views are workspace scoped views. For example hiding a repository change view does not impact the repository change view in another window. Is not the same expected when the repository changes view is moved? It is also clear from UI as these views are called differently in each workspace?
IMO logical grouping comes from specific area like SCM and may be as João Moreno (@joaomoreno) mentioned users can move SCM container in that case?
sbatten commentedon Apr 9, 2020
we do not currently do anything that would allow us to know that moving the SCM view container by dragging the SCM icon from the activity bar is a logical grouping. we could support this, but is this the intention?
I see the point about scm being workspace specific but we had not yet enabled view movement which is a much more obvious representation of differences between workspaces. i.e. if a user moves a view to the panel and every other view remembers its location, they should expect that scm does the same. i don't think users of single-repo (the most common case) think of each changes view as a different view. also the repository view is unique in that it only applies to workspaces with multiple repos and thus has some workspace context associated with it.
sbatten commentedon Apr 27, 2020
With view container movement, it would be possible to move the entire SCM container to the panel; however, we need to ensure that all SCM views will behave before allowing it. We should try this in debt week.
johncalvinyoung commentedon May 7, 2020
As a user who usually has multiple repos in workspace scope who badly wants to move the SCM view around, I'm alright treating the various change views as one view.
joaomoreno commentedon May 29, 2020
I've attempted to simply enable this, but given the reach onto the view model that the SCM Providers view has, it completely blew up. I need to postpone this for next month, sorry all!
sbatten commentedon Jun 26, 2020
fyi João Moreno (@joaomoreno) 3158fc0
joaomoreno commentedon Jun 26, 2020
Awesome, thanks! Let's close this!