Adopt Output panel to use views #89993

Activity

1. Sandeep Somavarapu (sandy081)

   added

   debtCode quality issuesCode quality issues

   workbench-viewsWorkbench view issuesWorkbench view issues

   on Feb 4, 2020
2. Sandeep Somavarapu (sandy081)

   added this to the February 2020 milestone on Feb 4, 2020
3. Sandeep Somavarapu (sandy081)

   self-assigned this

   on Feb 4, 2020
4. Sandeep Somavarapu (sandy081)

   added 2 commits that reference this issue on Feb 4, 2020

   #89993 Enhance views service

   ...

   d60bf23

   #89993 use composite's instantiation service

   aad809c
5. sandy081 commented on Feb 4, 2020

   

   Sandeep Somavarapu (sandy081)

   on Feb 4, 2020

   MemberAuthor

   More actions

   SteVen Batten (@sbatten) Needed more API in IViewsService for moving output panel to output view and added them. Most importantly these new APIs replaces the usage of panel service. It has to be make sure while adopting other panels or side bar views that they should not be using panel or viewlet service and to be replaced by IViewsService. Here are the new APIs added to IViewsService:

   readonly onDidChangeViewVisibility: Event<{ id: string, visible: boolean }>;
   isViewVisible(id: string): boolean;
   
   closeView(id: string): void;

   Also moved registering viewlets and panels from View Containers into ViewsService. So this makes it a service that talks to viewlets and panels. Hence we shall replace all usages of panels service and viewlet service in views and panels to use IViewsService.
6. Sandeep Somavarapu (sandy081)

   closed this as completedin 6b54950on Feb 4, 2020
7. vscodebot

   locked and limited conversation to collaborators on Mar 20, 2020