Skip to content

Test: GitHub PR Extension - new commenting API #71103

Description

Complexity: 3

Authors: Peng Lyu (@rebornix), Rachel Macfarlane (@RMacfarlane)

This iteration, we created a new proposed commenting API (#68020) and adopted it in the GitHub PR extension. This is to test that all commenting functionality behaves as before. Test that

  • Within an editor, you can create new comment threads, and reply to previously existing ones
  • You are able to edit and delete comments
  • You can start, finish, and delete a review from within the editor
  • When a comment is part of an unfinished review, it should have the label "Pending"
  • If you enter text in a comment without adding it and switch editors, the text is preserved when you return to the editor

Please test against the nightly version of the extension, which should have the most recent changes:
https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github-insiders

And file issues in this repo: https://github.com/Microsoft/vscode-pull-request-github

You can use https://github.com/auchenberg/pullrequest-demo for testing

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions