Breadcrumb dropdown uses confusing indentation

[gjsjohnmurray]

• VSCode Version: 1.28.2
• OS Version: Windows 10

When an entry in the breadcrumb dropdown is expandable its icon is preceded by the indicator with which to expand it. But non-expandable entries at the same level don't have equivalent whitespace, so the alignment of siblings is confusing. Below is a screenshot from a file in the vscode-mock-debug sample.

[jrieken]

This is the workbench themable tree configuration...

[aeschli]

If a theme specifies that it has no folder icons, the file explorer aligns the arrow and the file icons on the same level.
But it looks like the breadcrumb still adds icons to container (non-leaf) elements, so that doesn't work anymore.
Maybe you need to do a hybrid way of indenting: for the file/ folder level, do it as the explorer, for member level, use the regular way.
Or, don't hide container icons if the file icon theme doesn't have folders.

[gjsjohnmurray]

#28974 discussed an apparently similar issue in Explorer. At one stage there was an experiment with a blank placeholder icon to correct alignments in a generic way, but that was unpopular and got reverted.

Maybe the blank placeholder strategy would be okay in the breadcrumb dropdown.

Or how about putting the twistie after the icon in the dropdown entries that need both?