Explore update to Electron 4

[bpasero]

VSCode Exploration Builds with Electron 4.0.x:

• macOS: Download
• Linux: Download
• Windows: Download

[bpasero]

Daniel Imms (@Tyriar) for some bizarre reason, vscode-nsfw fails to load for me even though I can compile it. This is on Windows 10:

[Astrantia]

When will be Electron 3 pushed to insiders and Electron 4 pushes to exploration?

[bpasero]

Astrantia current idea is January 2019.

[Tyriar]

Benjamin Pasero (@bpasero) weird, is the nsfw.node file there and/or is it trying to load the module from asar?

[bpasero]

I think it was there.

[bpasero]

Daniel Imms (@Tyriar) this is when running out of sources, so ASAR is not involved. And I just checked, the nsfw.node file is there.

[bpasero]

Daniel Imms (@Tyriar) I am not convinced this is an issue with vscode-nsfw because I can compile it with node.js 10.11.0, so I opened electron/electron#15436

[bpasero]

Daniel Imms (@Tyriar) looks like this might be caused by nsfw setting this in binding.gyp:

"win_delay_load_hook": "false"

See electron/electron#15436 (comment)

However I am still struggling to load the module even after making this change: Axosoft/nsfw@master...Microsoft:electron-4.0.x

[bpasero]

I published vscode-nsfw@1.1.2 which should take care of this.

[dalDevelo]

Benjamin Pasero (@bpasero) I've used the provided link to download the electron 4 build for macOS. Immediately after install, running 'process.versions.electron' in dev tools reports that v4.0.0 beta.7 is being used, however as soon as the application updates, the electron version number is rolled back to v3.0.9. Is this supposed to be the case, or is there something at your end that needs to be changed so that this build looks in a different location for electron 4 related 'exploration' updates?