Skip to content

Press any key to close message gets written before process output is finished for background terminals #23051

New issue
New issue
Closed
Closed
Press any key to close message gets written before process output is finished for background terminals#23051
Assignees
Tyriar
Labels
bugIssue identified by VS Code Team member as probable bugterminalGeneral terminal issues that don't fall under another labelverifiedVerification succeeded
Milestone
April 2017

Description

@dbaeumer
Dirk Bäumer (dbaeumer)
opened on Mar 22, 2017
  • VSCode Version: master

I can a task and request the terminal to print the 'Press any key to close the terminal' message. However the message is printed to the terminal before the actual output of the task.

Press any key to close the terminal
 Volume in drive C is OSDisk
 Volume Serial Number is A63A-8EB4

 Directory of c:\Users\dirkb\Projects\mseng\VSCode\Playgrounds\tasks\client

22-Mar-17  21:34    <DIR>          .
22-Mar-17  21:34    <DIR>          ..
22-Mar-17  22:17                34 client.js
22-Mar-17  22:17                97 client.js.map
17-Feb-17  18:29                 0 client.ts
               3 File(s)            131 bytes
               2 Dir(s)  354,157,559,808 bytes free

I actually run two tasks in two terminal in parallel. The task in the terminal that is in front prints correctly to the terminal. The other not. In addition to the wrong placement of the message the terminal doesn't have a scroll bar either.

Activity

  1. Dirk Bäumer (dbaeumer)
    assigned
    Daniel Imms (Tyriar)
    on Mar 22, 2017
  2. Dirk Bäumer (dbaeumer)
    added
    terminalGeneral terminal issues that don't fall under another label
    bugIssue identified by VS Code Team member as probable bug
    on Mar 22, 2017

  3. Tyriar commented on Mar 23, 2017

    @Tyriar
    Daniel Imms (Tyriar)
    on Mar 23, 2017
    Contributor

    Scroll bar issue: #20505

  4. Daniel Imms (Tyriar)
    added this to the April 2017 milestone on Mar 23, 2017

  5. Tyriar commented on Apr 3, 2017

    @Tyriar
    Daniel Imms (Tyriar)
    on Apr 3, 2017
    Contributor

    I can repro this by forcing waitOnExit in TerminalInstance and setting up the shell exe/args like this:

        "terminal.integrated.shell.windows": "C:\\WINDOWS\\Sysnative\\cmd.exe",
    "terminal.integrated.shellArgs.windows": [
        "/c",
        "tree"
    ]

    Then creating 2 instances and waiting for the background one to finish.

    image

  6. Daniel Imms (Tyriar)
    changed the title [-]Strange terminal behaviour[/-] [+]Press any key to close message gets written before process output is finished for background terminals[/+] on Apr 3, 2017

  7. Tyriar commented on Apr 3, 2017

    @Tyriar
    Daniel Imms (Tyriar)
    on Apr 3, 2017
    Contributor

    Similar repro works on Linux.

    Looks like it's related to this https://github.com/Tyriar/node-pty/blob/884aa0b3e8ae548c69865d8631e5885bcdcd5fdd/src/unixTerminal.ts#L66

  8. Daniel Imms (Tyriar)
    closed this as completedin 9464b54on Apr 3, 2017
  9. Dirk Bäumer (dbaeumer)
    added
    verifiedVerification succeeded
    on Apr 28, 2017
  10. vscodebot
    locked and limited conversation to collaborators on Nov 18, 2017
  11. Mandeep Singh (meSingh)
    added a commit that references this issue on Sep 6, 2026

    Ensure no data events occur after a terminal's exit event fires

    5115bee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugterminalGeneral terminal issues that don't fall under another labelverifiedVerification succeeded

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions