Skip to content

node-pty throws on arm64 product build #225355

New issue
New issue
Closed
#225412
Closed
node-pty throws on arm64 product build#225355
#225412
Assignees
Tyriar
Labels
bugIssue identified by VS Code Team member as probable bugterminal-processProblems launching processes, managing ptys, exiting, process leaks, etc.upstreamIssue identified as 'upstream' component related (exists outside of VS Code)upstream-issue-fixedThe underlying upstream issue has been fixedupstream-issue-linkedThis is an upstream issue that has been reported upstreamverifiedVerification succeededvscode-buildVS Code build process issueswindowsVS Code on Windows issues
Milestone
August 2024

Description

@Tyriar
Daniel Imms (Tyriar)
opened on Aug 11, 2024

When setting "terminal.integrated.experimental.windowsUseConptyDll": true on an arm64 machine:

image

Think I need to properly support npm_config_arch in node-pty

Activity

  1. Daniel Imms (Tyriar)
    added
    bugIssue identified by VS Code Team member as probable bug
    vscode-buildVS Code build process issues
    windowsVS Code on Windows issues
    terminal-processProblems launching processes, managing ptys, exiting, process leaks, etc.
    on Aug 11, 2024
  2. Daniel Imms (Tyriar)
    added this to the August 2024 milestone on Aug 11, 2024
  3. Daniel Imms (Tyriar)
    self-assigned this
    on Aug 11, 2024
  4. Daniel Imms (Tyriar)
    added a commit that references this issue on Aug 11, 2024

    Copy right dll/exe based on npm_config_arch

    4f2f641

  5. Tyriar commented on Aug 11, 2024

    @Tyriar
    Daniel Imms (Tyriar)
    on Aug 11, 2024
    ContributorAuthor

    microsoft/node-pty#704

  6. Daniel Imms (Tyriar)
    added
    upstreamIssue identified as 'upstream' component related (exists outside of VS Code)
    upstream-issue-linkedThis is an upstream issue that has been reported upstream
    upstream-issue-fixedThe underlying upstream issue has been fixed
    on Aug 11, 2024
  7. Daniel Imms (Tyriar)
    added a commit that references this issue on Aug 12, 2024

    Update node-pty, use right binary on arm64

    22f6515
  8. Daniel Imms (Tyriar)
    closed this as completedin #225412on Aug 12, 2024
  9. Daniel Imms (Tyriar)
    closed this as completedin 22f6515on Aug 12, 2024
  10. Connor Peet (connor4312)
    added
    verifiedVerification succeeded
    on Aug 29, 2024
  11. vs-code-engineering
    locked and limited conversation to collaborators on Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugterminal-processProblems launching processes, managing ptys, exiting, process leaks, etc.upstreamIssue identified as 'upstream' component related (exists outside of VS Code)upstream-issue-fixedThe underlying upstream issue has been fixedupstream-issue-linkedThis is an upstream issue that has been reported upstreamverifiedVerification succeededvscode-buildVS Code build process issueswindowsVS Code on Windows issues

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions