Test: terminal quick fix widget

Devin Valenciano (@devinvalenciano)

Refs #162067

Windows Devin Valenciano (@devinvalenciano)
macOS Sandeep Somavarapu (@sandy081)
Linux Connor Peet (@connor4312)
Windows Ladislau Szomoru (@lszomoru)

Complexity: 3

Authors: Megan Rogge (@meganrogge) Daniel Imms (@Tyriar) Matt Bierner (@mjbvz)

We now have an ActionWidgetService used by both the code actions in the editor and the quick fixes in the terminal. Make sure that the widget works as expected in the terminal and feels consistent with the experience in an editor.

The quick fixes we support currently include:

git similar : git sttatus
git push : checkout a branch that has no upstream and git push
git create PR : git push --set-upstream origin <branch-name>
git two dashes: git add . -all
free port : launch a server or task that uses a specific <port> then launch that again so you see an error related to address already in use - example

Megan Rogge (@meganrogge)

Megan Rogge (@meganrogge) Do you mean this widget in the terminal?

Also, I tried to add quick fixes using following contribution and I do not know why I do not see it

"terminal": {
			"quickFixes": [
				{
					"id": "terminal-sample fix",
					"commandLineMatcher": "echo [^\\s]+",
					"outputMatcher": {
						"lineMatcher": "(?<input>[^\\s]+) (?<inputtwo>[^\\s]+)",
						"anchor": "bottom",
						"length": 1,
						"offset": 0
					},
					"linkToOpen": "https://google.com/${group:input}${group:inputtwo}",
				}
			]
		}

Got this sample from here

PS: It would be great, if the description of the test plan item has more context about what is being tested and some samples/references that can be helpful for testing.

Sandeep Somavarapu (@sandy081)

Sandeep Somavarapu (@sandy081) run git stt for example, you should see a lightbulb that opens a widget like this:

See release notes and docs for more examples: https://code.visualstudio.com/updates/v1_72#_terminal-quick-fixes, https://code.visualstudio.com/docs/terminal/shell-integration#_quick-fixes

Sandeep Somavarapu (@sandy081)

Sandeep Somavarapu (@sandy081) sorry for the confusion/ lack of directions. we just care about testing the functionality of the quick fix widget in this issue - no need to test the contribution point. I've updated the instructions above.

For example:

Thanks for the updated description.

I am not seeing any decorations in the terminal. Am I missing a setting?

Ladislau Szomoru (@lszomoru)

Ladislau Szomoru (@lszomoru) are you in screen reader mode, do you have the conpty setting overridden and what version of powershell are you on?

It was the conpty setting. Thank you!

Navigation Menu

Test: terminal quick fix widget #166761

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Test: terminal quick fix widget #166761

Description

Activity

sandy081 commented on Nov 29, 2022

Tyriar commented on Nov 29, 2022

meganrogge commented on Nov 29, 2022

sandy081 commented on Nov 29, 2022

lszomoru commented on Nov 30, 2022

Tyriar commented on Nov 30, 2022

lszomoru commented on Nov 30, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions