Repository navigation
VS Code - and Electron Apps generally - don't show Windows 11 SnapAssist on hover of Max #140932
Copy link
Copy link
Closed
Closed
Copy link
Labels
electronIssues and items related to ElectronIssues and items related to ElectrontitlebarVS Code main title bar issuesVS Code main title bar issuesupstreamIssue identified as 'upstream' component related (exists outside of VS Code)Issue identified as 'upstream' component related (exists outside of VS Code)upstream-issue-linkedThis is an upstream issue that has been reported upstreamThis is an upstream issue that has been reported upstreamwindowsVS Code on Windows issuesVS Code on Windows issues
Description
Activity
This is mentioned tangentially in electron/electron#32360 as well.
- addedwindowsVS Code on Windows issuesVS Code on Windows issuesworkbench-os-integrationNative OS integration issuesNative OS integration issues
on Jan 18, 2022 - assigned and unassigned
on Jan 18, 2022 shanselman commented
on Jan 18, 2022 MemberAuthorMore actionsChris Dias (@chrisdias) looks like Michaela Laurencin (@mlaurencin) is deep into it from the Electron side but it'd be nice to figure out "who owns" since it's starting at Chromium and working it's way up...but it's still not quite there https://bugs.chromium.org/p/chromium/issues/detail?id=1218921#c21 Maybe someone on your team can chat with her?
- addedelectronIssues and items related to ElectronIssues and items related to ElectronupstreamIssue identified as 'upstream' component related (exists outside of VS Code)Issue identified as 'upstream' component related (exists outside of VS Code)upstream-issue-linkedThis is an upstream issue that has been reported upstreamThis is an upstream issue that has been reported upstreamtitlebarVS Code main title bar issuesVS Code main title bar issuesand removedworkbench-os-integrationNative OS integration issuesNative OS integration issues
on Jan 18, 2022 Is this not a duplicate of #127449 ?
I kept it separate to track the upstream issue related to hover effect for WCO #140932 (comment)
Can be merged to #127449 as the relevant fixes are available with insiders.
Reacted by Benjamin Pasero- locked and limited conversation to collaborators
on Jul 15, 2022
Metadata
Metadata
Labels
electronIssues and items related to ElectronIssues and items related to ElectrontitlebarVS Code main title bar issuesVS Code main title bar issuesupstreamIssue identified as 'upstream' component related (exists outside of VS Code)Issue identified as 'upstream' component related (exists outside of VS Code)upstream-issue-linkedThis is an upstream issue that has been reported upstreamThis is an upstream issue that has been reported upstreamwindowsVS Code on Windows issuesVS Code on Windows issues
in Win 11 when you hover over the Maximize button you should see

This doesn't fire in VS Code, Teams (electron apps) or Windows Terminal (custom owner draw title bar)
The Electron Core (whomever is responsible for the Maximize button) needs to implement WM_NCHITTEST and reply with HTMAXBUTTON when the hit test is over top of the max button. That will tell Windows it's a Max button which helps Accessibility AND fires SnapAssist.