Skip to content

VS Code - and Electron Apps generally - don't show Windows 11 SnapAssist on hover of Max #140932

Description

in Win 11 when you hover over the Maximize button you should see
image

This doesn't fire in VS Code, Teams (electron apps) or Windows Terminal (custom owner draw title bar)

The Electron Core (whomever is responsible for the Maximize button) needs to implement WM_NCHITTEST and reply with HTMAXBUTTON when the hit test is over top of the max button. That will tell Windows it's a Max button which helps Accessibility AND fires SnapAssist.

image

Activity

  1. DHowett commented on Jan 18, 2022

    @DHowett
    Member

    This is mentioned tangentially in electron/electron#32360 as well.

  2. shanselman commented on Jan 18, 2022

    @shanselman
    MemberAuthor

    Chris Dias (@chrisdias) looks like Michaela Laurencin (@mlaurencin) is deep into it from the Electron side but it'd be nice to figure out "who owns" since it's starting at Chromium and working it's way up...but it's still not quite there https://bugs.chromium.org/p/chromium/issues/detail?id=1218921#c21 Maybe someone on your team can chat with her?

  3. added
    electronIssues and items related to Electron
    upstreamIssue identified as 'upstream' component related (exists outside of VS Code)
    upstream-issue-linkedThis is an upstream issue that has been reported upstream
    titlebarVS Code main title bar issues
    and removed on Jan 18, 2022
  4. bpasero commented on May 31, 2022

    @bpasero
    Contributor

    Is this not a duplicate of #127449 ?

  5. deepak1556 commented on May 31, 2022

    @deepak1556
    Collaborator

    I kept it separate to track the upstream issue related to hover effect for WCO #140932 (comment)

    Can be merged to #127449 as the relevant fixes are available with insiders.

  6. locked and limited conversation to collaborators on Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

electronIssues and items related to ElectrontitlebarVS Code main title bar issuesupstreamIssue identified as 'upstream' component related (exists outside of VS Code)upstream-issue-linkedThis is an upstream issue that has been reported upstreamwindowsVS Code on Windows issues

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions