Skip to content

Improve handling of webgl context loss #120393

New issue
New issue
Closed
#120400
Closed
Improve handling of webgl context loss#120393
#120400
Assignees
meganrogge
Labels
bugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code InsidersterminalGeneral terminal issues that don't fall under another labelterminal-renderingverifiedVerification succeeded
Milestone
April 2021

Description

@Tyriar
Daniel Imms (Tyriar)
opened on Apr 2, 2021

We should adopt xtermjs/xterm.js#3276. An easy fix is to just fallback when this happens, we need to make sure we don't save suggested renderer type if the webgl renderer is good though.

Activity

  1. Daniel Imms (Tyriar)
    added
    bugIssue identified by VS Code Team member as probable bug
    terminalGeneral terminal issues that don't fall under another label
    terminal-rendering
    on Apr 2, 2021
  2. Daniel Imms (Tyriar)
    added this to the April 2021 milestone on Apr 2, 2021
  3. Daniel Imms (Tyriar)
    assigned
    Megan Rogge (meganrogge)
    on Apr 2, 2021
  4. Megan Rogge (meganrogge)
    closed this as completedin #120400on Apr 2, 2021
  5. VS Code Issue Triage Bot (vscode-triage-bot)
    added
    unreleasedPatch has not yet been released in VS Code Insiders
    insiders-releasedPatch has been released in VS Code Insiders
    and removed
    unreleasedPatch has not yet been released in VS Code Insiders
    on Apr 2, 2021

  6. connor4312 commented on Apr 29, 2021

    @connor4312
    Connor Peet (connor4312)
    on Apr 29, 2021
    Member

    Can you add verification steps?

  7. Connor Peet (connor4312)
    added
    verification-steps-neededSteps to verify are needed for verification
    on Apr 29, 2021

  8. meganrogge commented on Apr 29, 2021

    @meganrogge
    Megan Rogge (meganrogge)
    on Apr 29, 2021
    Collaborator

    To verify:

    Context loss is achieved at a diff't limit for each computer.

    Using VS code stable - create as many terminals as needed to trigger context loss. When you reach that state, you'll see context loss

    Now in Insider's, create the same number of terminals. You shouldn't see any of those context loss images.

  9. Megan Rogge (meganrogge)
    removed
    verification-steps-neededSteps to verify are needed for verification
    on Apr 29, 2021

  10. connor4312 commented on Apr 29, 2021

    @connor4312
    Connor Peet (connor4312)
    on Apr 29, 2021
    Member

    very nice, I like how the fallback magically works

  11. Connor Peet (connor4312)
    added
    verifiedVerification succeeded
    on Apr 29, 2021
  12. github-actions
    locked and limited conversation to collaborators on May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code InsidersterminalGeneral terminal issues that don't fall under another labelterminal-renderingverifiedVerification succeeded

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions