Bundle d.ts files using api-extractor#245
Closed
mjbvz wants to merge 1 commit into
Closed
Conversation
This bundles all of the d.ts files into a single entrypoint using `api-extractor`. This reduces the package size and also fixes the typings when using `node16`/`nodenext`. These can't resolve the extension-less imports in current version of the typings
alexdima
reviewed
Dec 12, 2024
Member
alexdima
left a comment
alexdima
left a comment
There was a problem hiding this comment.
I'm not sure if the extra api-extractor script is invoked as part of the build.
| "prepublishOnly": "tsc && webpack --progress", | ||
| "bundle": "webpack" | ||
| "prepublishOnly": "tsc && webpack --progress && npm run api-extractor", | ||
| "bundle": "webpack", |
Member
There was a problem hiding this comment.
Should npm run api-extractor be also invoked by the bundle script? The build files seem to invoke npm run bundle and I don't know if prepublishOnly is invoked as part of our npm package publishing. Maybe we can trigger a build to check the package contents? But that would require that you port your changes to a branch in this repository, since forks can't be built.
Merged
Contributor
Author
|
Resubmitted as branch on main repo so we can create a test build : #246 Also added running api-extractor to |
auto-merge was automatically disabled
December 13, 2024 00:20
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bundles all of the d.ts files into a single
d.tsusingapi-extractor. This reduces the package size and also fixes the typings when usingnode16/nodenext. These module resolution strategies can't resolve the extension-less imports that are used the current version of the typings