Skip to content

Implements flag "containsBalancedBrackets"#170

Merged
alexdima merged 4 commits into
mainfrom
hediet/containsBalancedBrackets
Apr 7, 2022
Merged

Implements flag "containsBalancedBrackets"#170
alexdima merged 4 commits into
mainfrom
hediet/containsBalancedBrackets

Conversation

@hediet
Copy link
Copy Markdown
Member

@hediet hediet commented Apr 6, 2022 •
edited
Loading

Follow ups:

  • Ensure that many foreground-colors don't cause an overflow for background colors, as only 255 different colors are now available for the background and both background and foreground colors share the same color pool.
  • Refactor the code. Use the trie to check for this selector.

@hediet hediet force-pushed the hediet/containsBalancedBrackets branch from 9ae9e4d to 2d4d3c8 Compare April 6, 2022 22:30
@hediet hediet requested a review from alexdima April 6, 2022 22:32
@hediet hediet mentioned this pull request Apr 6, 2022
Merged
@alexdima alexdima merged commit 12f0e7a into main Apr 7, 2022
@alexdima alexdima deleted the hediet/containsBalancedBrackets branch April 7, 2022 12:16
@josecelano josecelano mentioned this pull request Oct 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexdima alexdima alexdima approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hediet @alexdima