Fix: parse mypy diagnostics from stderr in non_interactive mode#375
Merged
karthiknadig merged 1 commit intomicrosoft:mainfrom Sep 12, 2025
Merged
Conversation
…some configurations (e.g. non_interactive), mypy emits diagnostics on stderr.\nAggregate stdout+stderr when parsing so errors aren’t dropped when stdout is empty.\n\nFixes microsoft#364
karthiknadig
approved these changes
Sep 12, 2025
eleanorjboyd
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
mypyis run withnon_interactive = True, it can emit diagnostics tostderrinstead ofstdout. The extension currently parses onlystdout, resulting in no diagnostics being shown even though errors are present.Changes
stdoutorstderrhas content, aggregate both and parse the combined output. Continue loggingstdoutas before;stderris already logged separately.Rationale
non_interactiveoption is set #364 where diagnostics appear in logs but are not processed.Test Plan
setup.cfgorpyproject.tomlcontaining:Fixes #364