Skip to content

rollbar try catch #3985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Garrett Campbell (gcampbell-msft) merged 2 commits into from
Aug 16, 2024
Merged

rollbar try catch #3985

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f0753f
rollbar try catch
gcampbell-msft Aug 13, 2024
b447717
Merge branch 'main' into dev/gcampbell/Rollbar
qarni Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/rollbar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import * as logging from './logging';
import * as nls from 'vscode-nls';
import * as path from 'path';
import { logEvent } from './telemetry';
import * as lodash from "lodash";

nls.config({ messageFormat: nls.MessageFormat.bundle, bundleFormat: nls.BundleFormat.standalone })();
const localize: nls.LocalizeFunc = nls.loadMessageBundle();
Expand Down Expand Up @@ -76,7 +77,11 @@ class RollbarController {
* @returns The LogResult if we are enabled. `null` otherwise.
*/
exception(what: string, exception: Error, additional: object = {}): void {
log.fatal(localize('unhandled.exception', 'Unhandled exception: {0}', what), exception, JSON.stringify(additional, (key, value) => stringifyReplacer(key, value)));
try {
log.fatal(localize('unhandled.exception', 'Unhandled exception: {0}', what), exception, JSON.stringify(additional, (key, value) => stringifyReplacer(key, value)));
} catch (e) {
log.fatal(localize('unhandled.exception', 'Unhandled exception: {0}', what), exception, lodash.toString(additional));
}
const callstack = cleanStack(exception.stack);
const message = cleanString(exception.message);
logEvent('exception2', { message, callstack });
Expand Down