Fix2353 - Fix active build configuration warning coming from cpptools - #3267
Merged
Andreea Isac (andreeis) merged 3 commits intoJul 31, 2023
Conversation
Garrett Campbell (gcampbell-msft)
approved these changes
Jul 28, 2023
…configuration_warning
Andreea Isac (andreeis)
deleted the
dev/andris/cmake-tools/fix2353-Active_build_configuration_warning
branch
July 31, 2023 16:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #2353: active build configuration warning coming from CppTools. This happens when we don't have a cache yet, when "configure" operates on an empty build. While querying for cmake build type (the multi-config or single-config way...) we get the conclusions and decisions wrong.
There were more ways to fix this but I found redundancy with code in cmakeProject.currentBuildType and that actually looks like following a very thorough and good logic. It was also called before for kits case (but inside its implementation handles presets as well). It contains all the fixes I was considering earlier to do. Cleanest is to just call that. It looks like it's meant to handle the whole logic that I replace now with it.